Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(archives): correct recording metadata in S3 tags #105

Merged
merged 2 commits into from
Nov 21, 2023
Merged

fix(archives): correct recording metadata in S3 tags #105

merged 2 commits into from
Nov 21, 2023

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Oct 13, 2023 •
edited
Loading

Cleans up some archived recording metadata handling and ensures that the jvmId and connectUrl labels get applied.

Related to #62

To test:

  1. ./mvnw clean verify
  2. ./smoketest.bash -OXtb, wait for everything to come up
  3. Select a target ex. Podman > service:jmx:rmi:///jndi/rmi://sample-app:9093/jmxrmi
  4. Recordings > Create > create a recording
  5. Wait a few seconds, then archive that recording
  6. Go to Archives > All Archives > expand the target
  7. Check that the archived recording is present and has the expected labels

Before:
image
(notice that the connectUrl label is actually the jvmId, and there is no jvmId label)

After:
image

@andrewazores andrewazores added the feat New feature or request label Oct 13, 2023
@andrewazores
Copy link
Member Author

/build_test

@github-actions GitHub Actions
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/6934496324

1 similar comment
@github-actions GitHub Actions
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/6934496324

@andrewazores andrewazores force-pushed the recordings-metadata-storage branch 2 times, most recently from 6fda4f5 to 9481e18 Compare November 21, 2023 17:56
@andrewazores andrewazores changed the title feat(archives): include recording metadata in S3 tags chore(archives): refactor recording metadata in S3 tags Nov 21, 2023
@andrewazores
Copy link
Member Author

/build_test

@andrewazores andrewazores marked this pull request as ready for review November 21, 2023 18:03
@github-actions GitHub Actions
Copy link

Workflow started at 11/21/2023, 1:03:34 PM. View Actions Run.

@github-actions GitHub Actions
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/6947800843

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions GitHub Actions
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/6947800843

@andrewazores andrewazores changed the title chore(archives): refactor recording metadata in S3 tags fix(archives): correct recording metadata in S3 tags Nov 21, 2023
aali309
aali309 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@andrewazores andrewazores merged commit de4db51 into main Nov 21, 2023
24 of 25 checks passed
@andrewazores andrewazores deleted the recordings-metadata-storage branch November 21, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aali309 aali309 aali309 approved these changes

@mwangggg mwangggg Awaiting requested review from mwangggg

Assignees
No one assigned
Labels
feat New feature or request safe-to-test
Projects
No open projects
3.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewazores @aali309