-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(db): update references to split-out database container #136
Conversation
c04f658
to
8586f49
Compare
This PR/issue depends on:
|
is there any reason the |
Hmm, that doesn't happen for me, and that change was just part of regenerating those files with I'm using a slightly older version of |
huh interesting... perhaps I also need to update kompose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like the changelog explains it: https://github.com/kubernetes/kompose/releases/tag/v1.31.2 Very nice since we can deploy with current namespace instead of default^^ |
Let's also update the |
7cd96a6
to
14354c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Welcome to Cryostat3! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Fixes: #132
Based on #131
Depends on #131
See https://github.com/cryostatio/cryostat-db
See https://quay.io/repository/cryostat/cryostat-db?tab=tags