-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(itest): enable jfr-datasource recording upload test #140
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
3 similar comments
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
d440d9e
to
401c5dd
Compare
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
401c5dd
to
01b88b4
Compare
@andrewazores I think that you can keep UploadRecordingTest disabled, I will fix it after this update. |
integration tests seem to work fine locally but are consistently failing in CI. I'll look into why and ping you again for review @lkonno when I figure it out. |
9a2876e
to
38d0222
Compare
…define self custom target
…) to avoid CPU-count-based parallelism
38d0222
to
3a4886e
Compare
@lkonno the RulesPostJsonIT was already a little flakey before but somehow it seems to have become flakier with the changes to the StandardSelfTest base. I'll try to investigate that separately later on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lkonno I think this is properly cleaned up now. |
Welcome to Cryostat3! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Related to #42
Description of the change:
Re-enables the
UploadRecordingIT
with some modifications.