-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(smoketest): open services in browser tabs when ready #141
test(smoketest): open services in browser tabs when ready #141
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hmm the tabs aren't opening when I use the |
|
Yes that's the command I'm using and the browser tabs aren't opening. |
If you do I think this will still end up being contingent on the userhosts and |
c1fd6b7
to
1b4ebf8
Compare
yes, that command does open github in my browser |
Okay, so then I think the culprit must be the userhosts thing. |
Try You might still want to try to fix your userhosts setup at some point because IIRC the way that I set up the jfr-datasource and Grafana dashboard will require it in this smoketest. If you don't fix it then "View in Grafana" won't work, even if everything else does via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Related to #64
To test:
etc.