Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(image): correct expression condition syntax #145

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #144

https://github.com/cryostatio/cryostat3/actions/runs/6791664907/job/18463577147

I believe this failed because of the curly brace syntax. In my fork this was commented out to make sure it progressed to the "push to quay.io" stage and then failed as expected. Uncommenting this condition resulted in the JDK 21 build attempting to build the multiarch manifest image when it should have skipped that step.

@andrewazores andrewazores added ci build chore Refactor, rename, cleanup, etc. safe-to-test labels Nov 8, 2023
@andrewazores andrewazores requested a review from a team November 8, 2023 00:18
@andrewazores andrewazores merged commit 94742e3 into cryostatio:main Nov 8, 2023
19 of 26 checks passed
@andrewazores andrewazores deleted the ci-fixup branch November 8, 2023 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build chore Refactor, rename, cleanup, etc. ci safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant