Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(smoketest): add additional s3 impl options #157

Merged
merged 6 commits into from
Nov 20, 2023

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Nov 9, 2023

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #67

To test:

$ USE_USERHOSTS=false ./smoketest.bash -bs cloudserver
$ USE_USERHOSTS=false ./smoketest.bash -bs seaweed
$ USE_USERHOSTS=false ./smoketest.bash -bs localstack
$ USE_USERHOSTS=false ./smoketest.bash -bs minio

All four of these should spin up and result in a working deployment with the same basic Cryostat functionalities. Minio will additionally open its admin console/file explorer.

@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Nov 9, 2023
@andrewazores andrewazores added test safe-to-test and removed needs-triage Needs thorough attention from code reviewers labels Nov 9, 2023
@andrewazores andrewazores changed the title test(smoketest): add cloudserver s3 impl option test(smoketest): add additional s3 impl options Nov 9, 2023
@andrewazores andrewazores force-pushed the smoketest-cloudserver branch 3 times, most recently from 3346ebe to d9807e2 Compare November 14, 2023 15:37
@andrewazores andrewazores force-pushed the smoketest-cloudserver branch 2 times, most recently from 55d317b to d88083c Compare November 20, 2023 15:47
@andrewazores
Copy link
Member Author

@aali309 @mwangggg ping

@aali309
Copy link
Contributor

aali309 commented Nov 20, 2023

LGTM, all 4 tests work as expected.

@andrewazores andrewazores merged commit 4f4f12e into cryostatio:main Nov 20, 2023
7 checks passed
@andrewazores andrewazores deleted the smoketest-cloudserver branch November 20, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants