-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eventtemplates): custom event templates in S3 #290
Conversation
711c0fe
to
ab40d5f
Compare
/build_test |
Workflow started at 2/15/2024, 2:44:28 PM. View Actions Run. |
CI build and push: All tests pass ✅ (JDK21) |
CI build and push: At least one test failed ❌ (JDK17) |
/build_test |
Workflow started at 2/15/2024, 3:06:13 PM. View Actions Run. |
CI build and push: All tests pass ✅ (JDK21) |
CI build and push: At least one test failed ❌ (JDK17) |
Figuring out the test failures. |
/build_test |
Workflow started at 2/15/2024, 10:22:00 PM. View Actions Run. |
CI build and push: All tests pass ✅ (JDK21) |
CI build and push: All tests pass ✅ (JDK17) |
/build_test |
Workflow started at 2/15/2024, 10:39:09 PM. View Actions Run. |
CI build and push: All tests pass ✅ (JDK21) |
CI build and push: All tests pass ✅ (JDK17) |
/build_test |
Workflow started at 2/15/2024, 10:50:52 PM. View Actions Run. |
CI build and push: All tests pass ✅ (JDK21) |
CI build and push: All tests pass ✅ (JDK17) |
059bc10
to
a356191
Compare
/build_test |
Workflow started at 2/21/2024, 3:32:05 PM. View Actions Run. |
CI build and push: All tests pass ✅ (JDK21) |
CI build and push: All tests pass ✅ (JDK17) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, was very nice seeing the outcome. Looks good to me.
Welcome to Cryostat3! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Fixes #13
Replaces #119
Related to #42
Description of the change:
This implements custom event template storage in S3. This works much the same as custom event templates do in 2.4.0, but rather than stored in a local filesystem location the templates are stored in and retrieved from S3.
How to manually test:
ALL
) - you should find ex.Profiling.jfc
downloaded to your workstation. This step requires chore(templates): remove auth token download flow cryostat-web#1215 . Without it, you can check your workstation's JVM installation and look for ex./usr/lib/jvm/java/lib/jfr/profile.jfc
and use that as a base, instead:cp /usr/lib/jvm/java/lib/jfr/profile.jfc ~/Downloads/Profiling.jfc
.Profiling.jfc
with a text or XML editor, or the JMC event configuration wizard. Make some changes to the event template file, including changing thelabel
,description
, andprovider
attributes at the top.This will display a notification but the UI table may not update - I think this is a -web bug. Navigating away and back to Events will show the correctly updated contents.