-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugins): implement plugin JWTs, ping/prune #339
Conversation
50b3f4c
to
e1e8db8
Compare
This PR/issue depends on:
|
/build_test |
Workflow started at 3/22/2024, 9:46:09 AM. View Actions Run. |
CI build and push: All tests pass ✅ (JDK21) |
No OpenAPI schema changes detected. |
CI build and push: At least one test failed ❌ (JDK17) |
/build_test |
Workflow started at 3/22/2024, 9:57:13 AM. View Actions Run. |
CI build and push: All tests pass ✅ (JDK21) |
No OpenAPI schema changes detected. |
CI build and push: All tests pass ✅ (JDK17) |
18a8538
to
5293d25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
CI build and push: All tests pass ✅ (JDK21) |
No OpenAPI schema changes detected. |
CI build and push: All tests pass ✅ (JDK17) |
5293d25
to
8e2e0bb
Compare
/build_test |
Workflow started at 3/27/2024, 1:35:55 PM. View Actions Run. |
CI build and push: All tests pass ✅ (JDK21) |
No OpenAPI schema changes detected. |
CI build and push: All tests pass ✅ (JDK17) |
Welcome to Cryostat3! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Fixes: #189
Fixes #10
Based on #337
Description of the change:
This fixes up the current half-baked discovery plugin system and brings it up to parity with 2.4's implementation. The JWT dependency and creation and validation logic was a copy-paste from 2.4 with minor adjustments for dependency injection and some refactoring at callsites or method signatures to work with or fit better into the Quarkus style.
Also,
How to manually test:
curl
orhttp
and try to make requests to the various/api/v2.2/discovery
plugin endpoints. Without a valid JWT you should not be permitted to make any actions now. Previously you would be able to ex. deregister a plugin or publish information on its behalf, even without knowing a valid JWT corresponding to that plugin and its realm.