feat(about): reimplement git build info in /health #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-triage
andrewazores
force-pushed
the
git-version
branch
from
44feb73
to
7408e90
Compare
andrewazores
added
feat
andrewazores
changed the title
andrewazores
force-pushed
the
git-version
branch
from
75e1182
to
c2c9397
Compare
andrewazores
changed the title
7 tasks
andrewazores
force-pushed
the
git-version
branch
from
eede010
to
cba3919
Compare
mwangggg
reviewed
Aug 29, 2024
andrewazores
force-pushed
the
git-version
branch
from
cba3919
to
2d3fe22
Compare
|
/build_test |
|
Workflow started at 8/29/2024, 12:12:29 PM. View Actions Run. |
|
No OpenAPI schema changes detected. |
|
No GraphQL schema changes detected. |
|
CI build and push: All tests pass ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainRelated to #550
Description of the change:
Stores the output of
git rev-parseinMETA-INF/gitinfosimilar to what the 2.x build did withgit describe. Then,GET /healthincludes this string in its output as a nested JSON property, rather than replacing the version string.Motivation for the change:
Easier identification of development builds and linking to exact sources for all builds.
How to manually test:
./smoketest.bash -Okhttp :8080/health