Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jdk): upgrade to JDK21 #651

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Sep 16, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Depends on #609
Depends on cryostatio/cryostat-reports#275
Depends on cryostatio/jfr-datasource#326
Based on #609
Fixes #364

Description of the change:

This change allows an environment variable to be configured so that...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
  2. ...

@andrewazores andrewazores added dependencies Pull requests that update a dependency file chore Refactor, rename, cleanup, etc. safe-to-test labels Sep 16, 2024
@github-actions github-actions bot added dependent needs-triage Needs thorough attention from code reviewers and removed dependent labels Sep 16, 2024
@andrewazores andrewazores removed the needs-triage Needs thorough attention from code reviewers label Sep 16, 2024
@andrewazores andrewazores changed the title chore(jdk): upgrade to JDK21 on UBI9 chore(jdk): upgrade to JDK21 Sep 17, 2024
Copy link

@andrewazores andrewazores marked this pull request as ready for review September 30, 2024 15:44
@andrewazores andrewazores requested a review from a team as a code owner September 30, 2024 15:44
@andrewazores andrewazores reopened this Sep 30, 2024
@andrewazores
Copy link
Member Author

/build_test

@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Sep 30, 2024
Copy link

Workflow started at 9/30/2024, 11:45:29 AM. View Actions Run.

@andrewazores andrewazores removed the needs-triage Needs thorough attention from code reviewers label Sep 30, 2024
Copy link

CI build and push: At least one test failed ❌
https://github.com/cryostatio/cryostat/actions/runs/11109579821

@andrewazores
Copy link
Member Author

^ failure because the change to update the CI is included in this changeset too, so the CI runner is still trying to use JDK 17 to build and run this, but it requires 21+.

@andrewazores andrewazores merged commit bcbdf92 into cryostatio:main Sep 30, 2024
14 of 15 checks passed
@andrewazores andrewazores deleted the ubi9-jdk21 branch September 30, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. dependencies Pull requests that update a dependency file safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Upgrade to Quarkus 3.8 LTS and JDK 21
1 participant