Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(quarkus): upgrade to 3.8 LTS #687

Open
wants to merge 7 commits into
base: cryostat-v3.0
Choose a base branch
from

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Oct 8, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #688

Description of the change:

This change allows an environment variable to be configured so that...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
  2. ...

* build(deps): update Quarkus to 3.8 LTS

* add hibernate format mapper override

* remove no longer necessary lazy init

* disable openapi management / swagger UI unless in dev mode

* remove duplicate healthcheck override

* reduce healthcheck start periods

* correct healthcheck URL

* use authproxy image which contains wget for healthcheck

* correct healthchecks for vertx agent test applications
@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Oct 8, 2024
@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. safe-to-test and removed needs-triage Needs thorough attention from code reviewers labels Oct 8, 2024
@andrewazores
Copy link
Member Author

/build_test

Copy link

github-actions bot commented Oct 8, 2024

Workflow started at 10/8/2024, 4:23:37 PM. View Actions Run.

Copy link

github-actions bot commented Oct 8, 2024

No GraphQL schema changes detected.

Copy link

github-actions bot commented Oct 8, 2024

OpenAPI schema change detected:

diff --git a/schema/openapi.yaml b/schema/openapi.yaml
index ebb0470..207ef13 100644
--- a/schema/openapi.yaml
+++ b/schema/openapi.yaml
@@ -352,21 +352,21 @@ components:
 info:
   contact:
     email: [email protected]
     name: Cryostat Community
     url: https://cryostat.io
   description: Cloud-Native JDK Flight Recorder
   license:
     name: Apache 2.0
     url: https://github.com/cryostatio/cryostat3/blob/main/LICENSE
   title: Cryostat API
-  version: 3.0.1-snapshot
+  version: 3.0.2-snapshot
 openapi: 3.0.3
 paths:
   /api/beta/credentials/{connectUrl}:
     post:
       parameters:
         - in: path
           name: connectUrl
           required: true
           schema:
             type: string

Copy link

github-actions bot commented Oct 8, 2024

Schema changes committed by the CI.

Copy link

github-actions bot commented Oct 8, 2024

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat/actions/runs/11243153143

@andrewazores
Copy link
Member Author

Manually smoketested with smoketest.bash and things look good. Also checked in OpenShift using the Helm chart:

$ cd cryostat-helm
$ git checkout cryostat-v3.0
$ helm install cryostat --set authentication.openshift.enabled=true --set core.route.enabled=true --set core.image.repository=quay.io/andrewazores/cryostat --set core.image.tag=302-quarkus-38-1 ./charts/cryostat/

@andrewazores andrewazores marked this pull request as ready for review October 9, 2024 13:22
@andrewazores andrewazores requested a review from a team as a code owner October 9, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant