Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(smoketest): restore healthcheck, remove obsolete version declarations #713

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #609

Description of the change:

  1. Restores the Cryostat healthcheck which was disabled in build(deps): update Quarkus to 3.8 LTS #609. This mysteriously stopped working on that upgrade. Now after updating my workstation to Fedora 40, which comes with newer versions of docker-compose and things, it complained that the container did not have a defined healthcheck. Re-enabling the old one now seems to work.
  2. Removes the 'version' declarations from compose manifests. The newer docker-compose version warns that these declarations are deprecated/obsolete and will be ignored.

Motivation for the change:

After upgrading my workstation from Fedora 39 to 40, these changes are required for bash smoketest.bash -t to work as normal again.

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
  2. ...

@andrewazores andrewazores requested a review from a team November 25, 2024 15:50
@andrewazores andrewazores added test chore Refactor, rename, cleanup, etc. safe-to-test labels Nov 25, 2024
@andrewazores andrewazores merged commit c3efa62 into cryostatio:main Nov 25, 2024
14 of 15 checks passed
@andrewazores andrewazores deleted the smoketest-healthcheck branch November 25, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants