Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: Dependencies are not upgraded to latest #81

Merged
merged 5 commits into from
May 11, 2022
Merged

Problem: Dependencies are not upgraded to latest #81

merged 5 commits into from
May 11, 2022

Conversation

devashishdxt
Copy link
Collaborator

Solution: Upgraded dependencies and fixed clippy warnings

@devashishdxt
Problem: Dependencies are not upgraded to latest
23ef570 
Solution: Upgraded dependencies and fixed clippy warnings
@devashishdxt devashishdxt requested a review from tomtau March 7, 2022 08:57
tomtau
tomtau reviewed Mar 7, 2022
View reviewed changes
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have some integration test, or at least manual we can run?

@devashishdxt
Copy link
Collaborator Author

do we have some integration test, or at least manual we can run?

Right now, no. But, I've assigned #16 to myself and will start working on this next.

@devashishdxt devashishdxt requested a review from tomtau May 11, 2022 07:23
tomtau
tomtau approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some strange dependencies in the tree, e.g. parity-scale-codec, but I assume it's ok

tomtau
tomtau reviewed May 11, 2022
View reviewed changes
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those cargo audit issues are unrelated, still pending form #20 ?

@devashishdxt
Copy link
Collaborator Author

those cargo audit issues are unrelated, still pending form #20 ?

It comes from primitive-types crate which we're using for U256 type.

@devashishdxt devashishdxt merged commit 5678573 into crypto-com:main May 11, 2022
@devashishdxt devashishdxt deleted the dep-upgrade branch May 12, 2022 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomtau tomtau tomtau approved these changes

@allthatjazzleo allthatjazzleo Awaiting requested review from allthatjazzleo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devashishdxt @tomtau