-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: missing ADR for precompiled #1191
Draft
thomas-nguy
wants to merge
4
commits into
crypto-org-chain:main
Choose a base branch
from
thomas-nguy:thomas/adr-0010
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-nguy
requested review from
yihuang and
mmsqe
and removed request for
a team
October 2, 2023 09:03
thomas-nguy
force-pushed
the
thomas/adr-0010
branch
from
October 2, 2023 09:04
5cc829e
to
0dadeb8
Compare
thomas-nguy
changed the title
Problem: missing ADR for precompile
Problem: missing ADR for precompiled
Oct 2, 2023
thomas-nguy
force-pushed
the
thomas/adr-0010
branch
4 times, most recently
from
October 2, 2023 09:14
a4e2523
to
9d26c3a
Compare
thomas-nguy
commented
Oct 2, 2023
|
||
```go | ||
|
||
const ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmsqe Not sure why we are using a prefix based encoding rather than abi encoding like for all the other precompiled?
thomas-nguy
force-pushed
the
thomas/adr-0010
branch
2 times, most recently
from
October 2, 2023 09:28
40c222b
to
4be4a5c
Compare
thomas-nguy
force-pushed
the
thomas/adr-0010
branch
from
October 3, 2023 01:07
4be4a5c
to
29b27e3
Compare
thomas-nguy
force-pushed
the
thomas/adr-0010
branch
from
October 3, 2023 05:44
d8ffbaa
to
47daa4e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1191 +/- ##
===========================================
- Coverage 36.97% 16.73% -20.24%
===========================================
Files 115 79 -36
Lines 10235 5766 -4469
===========================================
- Hits 3784 965 -2819
+ Misses 6078 4723 -1355
+ Partials 373 78 -295 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
Draft for ADR-010
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)