Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: missing ADR for precompiled #1191

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

thomas-nguy
Copy link
Collaborator

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

Draft for ADR-010

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@thomas-nguy thomas-nguy requested a review from a team as a code owner October 2, 2023 09:03
@thomas-nguy thomas-nguy requested review from yihuang and mmsqe and removed request for a team October 2, 2023 09:03
@thomas-nguy thomas-nguy changed the title Problem: missing ADR for precompile Problem: missing ADR for precompiled Oct 2, 2023
@thomas-nguy thomas-nguy force-pushed the thomas/adr-0010 branch 4 times, most recently from a4e2523 to 9d26c3a Compare October 2, 2023 09:14

```go

const (
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmsqe Not sure why we are using a prefix based encoding rather than abi encoding like for all the other precompiled?

@thomas-nguy thomas-nguy marked this pull request as draft October 2, 2023 09:16
@thomas-nguy thomas-nguy force-pushed the thomas/adr-0010 branch 2 times, most recently from 40c222b to 4be4a5c Compare October 2, 2023 09:28
@thomas-nguy thomas-nguy requested a review from calvinaco October 3, 2023 10:27
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #1191 (0e1f1d5) into main (79c911c) will decrease coverage by 20.24%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1191       +/-   ##
===========================================
- Coverage   36.97%   16.73%   -20.24%     
===========================================
  Files         115       79       -36     
  Lines       10235     5766     -4469     
===========================================
- Hits         3784      965     -2819     
+ Misses       6078     4723     -1355     
+ Partials      373       78      -295     

see 54 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant