Fix inconsistey TraceCall signature

crypto-org-chain · Oct 25, 2023 · 1da357c · 1da357c
1 parent ee2b893
commit 1da357c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/rpc/backend/backend.go b/rpc/backend/backend.go
@@ -139,7 +139,7 @@ type EVMBackend interface {
 	// Tracing
 	TraceTransaction(hash common.Hash, config *evmtypes.TraceConfig) (interface{}, error)
 	TraceBlock(height rpctypes.BlockNumber, config *evmtypes.TraceConfig, block *tmrpctypes.ResultBlock) ([]*evmtypes.TxTraceResult, error)
-	TraceCall(args evmtypes.TransactionArgs, blockNr rpctypes.BlockNumber, config *evmtypes.TraceConfig) (interface{}, error)
+	TraceCall(args evmtypes.TransactionArgs, blockNr rpctypes.BlockNumberOrHash, config *evmtypes.TraceConfig) (interface{}, error)
 }
 
 var _ BackendI = (*Backend)(nil)

diff --git a/rpc/backend/tracing.go b/rpc/backend/tracing.go
@@ -206,12 +206,17 @@ func (b *Backend) TraceBlock(height rpctypes.BlockNumber,
 // TraceCall returns the structured logs created during the execution of EVM call
 // and returns them as a JSON object.
 func (b *Backend) TraceCall(
-	args evmtypes.TransactionArgs, blockNr rpctypes.BlockNumber, config *evmtypes.TraceConfig,
+	args evmtypes.TransactionArgs, blockNrOrHash rpctypes.BlockNumberOrHash, config *evmtypes.TraceConfig,
 ) (interface{}, error) {
 	bz, err := json.Marshal(&args)
 	if err != nil {
 		return nil, err
 	}
+	blockNr, err := b.BlockNumberFromTendermint(blockNrOrHash)
+	if err != nil {
+		return nil, err
+	}
+
 	blk, err := b.TendermintBlockByNumber(blockNr)
 	if err != nil {
 		// the error message imitates geth behavior