Skip to content

Commit

Permalink
removed listener closing in gracefully shutdown json-rpc server
Browse files Browse the repository at this point in the history
  • Loading branch information
valli0x committed Oct 31, 2024
1 parent 885530b commit a4794ad
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion server/json_rpc.go
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ func StartJSONRPC(
if err := httpSrv.Shutdown(context.Background()); err != nil {
logger.Error("failed to shutdown JSON-RPC server", "error", err.Error())
}
return ln.Close()
return err

Check warning on line 154 in server/json_rpc.go

View check run for this annotation

Codecov / codecov/patch

server/json_rpc.go#L154

Added line #L154 was not covered by tests

case err := <-errCh:
if err == http.ErrServerClosed {
Expand Down

0 comments on commit a4794ad

Please sign in to comment.