Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: concurrent write base fee in fee history (backport: #364) #366

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Oct 23, 2023

for more info

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

* Problem: fee history with baseFeePerGas is not tested

* only use NextBaseFee as last item to avoid concurrent write

* concurrent unit test

* update pystarport

* reproduce with param change
@mmsqe mmsqe requested a review from yihuang October 23, 2023 10:57
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #366 (bf383bd) into release/v0.20.x-cronos (3fdb18b) will decrease coverage by 0.01%.
The diff coverage is 37.50%.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           release/v0.20.x-cronos     #366      +/-   ##
==========================================================
- Coverage                   52.54%   52.53%   -0.01%     
==========================================================
  Files                         114      114              
  Lines                       11124    11129       +5     
==========================================================
+ Hits                         5845     5847       +2     
- Misses                       5029     5032       +3     
  Partials                      250      250              
Files Coverage Δ
rpc/backend/backend.go 50.00% <100.00%> (+3.33%) ⬆️
rpc/backend/chain_info.go 8.45% <0.00%> (-0.13%) ⬇️

@mmsqe mmsqe merged commit 830acf5 into crypto-org-chain:release/v0.20.x-cronos Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants