Problem: subscription refactoring not merged #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Problem: internal websocket connection is heavy and unstable Solution: - use local node client directly. * ignore duplicate subscriptions, it's possible in concurrency * bigger start timeout * handle error * fix lint * fix unit test * rename * fix test * remove test * add buffer
* implement stream * rpc stream * websocket use stream * filter apis use stream * cleanup * move modules * cleanup * fix cond race * fix lint * nit * fix build * fix lint * err return * fix empty logs * fix filter initial offset * fix filter * fix filter * fix test
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| }, api.logger, "closing websocket peer sub") | ||
| try(func() { | ||
| if err != websocket.ErrCloseSent { | ||
| _ = wsConn.Close() |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack. Warning
| if err != nil { | ||
| try(func() { | ||
| if err != websocket.ErrCloseSent { | ||
| _ = wsConn.Close() |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack. Warning
| api.logger.Debug("dropping NewHeads WebSocket subscription", "subscription-id", subID, "error", err.Error()) | ||
| try(func() { | ||
| if err != websocket.ErrCloseSent { | ||
| _ = wsConn.Close() |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack. Warning
mmsqe
approved these changes
Nov 14, 2023
sure, added. |
yihuang
added a commit
that referenced
this pull request
Nov 14, 2023
* Problem: internal websocket connection is heavy and unstable (#373) * Problem: internal websocket connection is heavy and unstable Solution: - use local node client directly. * ignore duplicate subscriptions, it's possible in concurrency * bigger start timeout * handle error * fix lint * fix unit test * rename * fix test * remove test * add buffer * Problem: channels are not efficient for broadcasting scenario (#374) * implement stream * rpc stream * websocket use stream * filter apis use stream * cleanup * move modules * cleanup * fix cond race * fix lint * nit * fix build * fix lint * err return * fix empty logs * fix filter initial offset * fix filter * fix filter * fix test * changelog * add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge the feature into develop branch.
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)