-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: go-ethereum is not updated #377
Conversation
for key, value := range t { | ||
storage[key] = make(Storage) | ||
for k, v := range value { | ||
storage[key][k] = v | ||
} | ||
} |
Check failure
Code scanning / gosec
the value in the range statement should be _ unless copying a map: want: for key := range m Error
@@ -62,7 +62,7 @@ | |||
Coinbase: cfg.CoinBase, | |||
GasLimit: ethermint.BlockGasLimit(ctx), | |||
BlockNumber: big.NewInt(ctx.BlockHeight()), | |||
Time: big.NewInt(ctx.BlockHeader().Time.Unix()), | |||
Time: uint64(ctx.BlockHeader().Time.Unix()), |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion Error
@@ -384,10 +385,18 @@ | |||
|
|||
// access list preparation is moved from ante handler to here, because it's needed when `ApplyMessage` is called | |||
// under contexts where ante handlers are not run, for example `eth_call` and `eth_estimateGas`. | |||
if rules := cfg.ChainConfig.Rules(big.NewInt(ctx.BlockHeight()), cfg.ChainConfig.MergeNetsplitBlock != nil); rules.IsBerlin { | |||
stateDB.PrepareAccessList(msg.From(), msg.To(), vm.DefaultActivePrecompiles(rules), msg.AccessList()) | |||
time := uint64(ctx.BlockHeader().Time.Unix()) |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion Error
30e5f88
to
3ce853f
Compare
@@ -35,8 +35,9 @@ | |||
height := big.NewInt(ctx.BlockHeight()) | |||
homestead := cfg.IsHomestead(height) | |||
istanbul := cfg.IsIstanbul(height) | |||
shanghai := cfg.IsShanghai(uint64(ctx.BlockHeader().Time.Unix())) |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion Error
@@ -162,6 +162,7 @@ | |||
blockHeight := big.NewInt(ctx.BlockHeight()) | |||
homestead := egcd.ethCfg.IsHomestead(blockHeight) | |||
istanbul := egcd.ethCfg.IsIstanbul(blockHeight) | |||
shanghai := egcd.ethCfg.IsShanghai(uint64(ctx.BlockHeader().Time.Unix())) |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion Error
67f7683
to
0a73909
Compare
3cdccaf
to
e05e0f6
Compare
abed9e4
to
51c43c0
Compare
// TODO: enable additional log configuration | ||
logCfg := &logger.Config{ | ||
Debug: true, | ||
} | ||
|
||
switch tracer { | ||
case TracerAccessList: | ||
preCompiles := vm.DefaultActivePrecompiles(cfg.Rules(big.NewInt(height), cfg.MergeNetsplitBlock != nil)) | ||
preCompiles := vm.DefaultActivePrecompiles(cfg.Rules(big.NewInt(height), cfg.MergeNetsplitBlock != nil, uint64(time))) |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion Error
replace PrepareAccessList to Prepare update deps
keep params_v4
Co-authored-by: yihuang <[email protected]> Signed-off-by: mmsqe <[email protected]>
for more info