Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: go-ethereum is not updated #377

Merged
merged 20 commits into from
Nov 22, 2023
Merged

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Nov 16, 2023

for more info

  v2 v3 v4 v5 v6
Migrate Set paramstore with disable allowUnprotectedTxs Set paramstore with new default chainConfig Set store separated keys Set store with param key with cleared eips Set store with param key with change from fork block to time
eips []int64 []int64 ExtraEIPs []int64 []int64
ChainConfig v0 chain config v0 chain config v0 chain config v0 chain config v1 chain config
KeyTable v0 legacy v0 legacy v0 legacy v0 legacy v0 legacy

Comment on lines +51 to +56
for key, value := range t {
storage[key] = make(Storage)
for k, v := range value {
storage[key][k] = v
}
}

Check failure

Code scanning / gosec

the value in the range statement should be _ unless copying a map: want: for key := range m Error

expected exactly 1 statement (either append, delete, or copying to another map) in a range with a map, got 2
x/evm/keeper/state_transition.go Fixed Show fixed Hide fixed
@@ -62,7 +62,7 @@
Coinbase: cfg.CoinBase,
GasLimit: ethermint.BlockGasLimit(ctx),
BlockNumber: big.NewInt(ctx.BlockHeight()),
Time: big.NewInt(ctx.BlockHeader().Time.Unix()),
Time: uint64(ctx.BlockHeader().Time.Unix()),

Check failure

Code scanning / gosec

Potential integer overflow by integer type conversion Error

Potential integer overflow by integer type conversion
@mmsqe mmsqe requested a review from yihuang November 16, 2023 01:18
x/evm/types/chain_config.go Outdated Show resolved Hide resolved
@@ -384,10 +385,18 @@

// access list preparation is moved from ante handler to here, because it's needed when `ApplyMessage` is called
// under contexts where ante handlers are not run, for example `eth_call` and `eth_estimateGas`.
if rules := cfg.ChainConfig.Rules(big.NewInt(ctx.BlockHeight()), cfg.ChainConfig.MergeNetsplitBlock != nil); rules.IsBerlin {
stateDB.PrepareAccessList(msg.From(), msg.To(), vm.DefaultActivePrecompiles(rules), msg.AccessList())
time := uint64(ctx.BlockHeader().Time.Unix())

Check failure

Code scanning / gosec

Potential integer overflow by integer type conversion Error

Potential integer overflow by integer type conversion
@mmsqe mmsqe force-pushed the bump_v1.11.0 branch 2 times, most recently from 30e5f88 to 3ce853f Compare November 16, 2023 06:47
@mmsqe mmsqe marked this pull request as ready for review November 16, 2023 10:16
x/evm/migrations/v6/migrate.go Fixed Show fixed Hide fixed
x/evm/migrations/v6/migrate.go Fixed Show fixed Hide fixed
@@ -35,8 +35,9 @@
height := big.NewInt(ctx.BlockHeight())
homestead := cfg.IsHomestead(height)
istanbul := cfg.IsIstanbul(height)
shanghai := cfg.IsShanghai(uint64(ctx.BlockHeader().Time.Unix()))

Check failure

Code scanning / gosec

Potential integer overflow by integer type conversion Error

Potential integer overflow by integer type conversion
@@ -162,6 +162,7 @@
blockHeight := big.NewInt(ctx.BlockHeight())
homestead := egcd.ethCfg.IsHomestead(blockHeight)
istanbul := egcd.ethCfg.IsIstanbul(blockHeight)
shanghai := egcd.ethCfg.IsShanghai(uint64(ctx.BlockHeader().Time.Unix()))

Check failure

Code scanning / gosec

Potential integer overflow by integer type conversion Error

Potential integer overflow by integer type conversion
@mmsqe mmsqe force-pushed the bump_v1.11.0 branch 2 times, most recently from 67f7683 to 0a73909 Compare November 20, 2023 01:13
@mmsqe mmsqe marked this pull request as draft November 20, 2023 01:21
@mmsqe mmsqe force-pushed the bump_v1.11.0 branch 2 times, most recently from 3cdccaf to e05e0f6 Compare November 21, 2023 02:07
@mmsqe mmsqe force-pushed the bump_v1.11.0 branch 4 times, most recently from abed9e4 to 51c43c0 Compare November 22, 2023 01:16
// TODO: enable additional log configuration
logCfg := &logger.Config{
Debug: true,
}

switch tracer {
case TracerAccessList:
preCompiles := vm.DefaultActivePrecompiles(cfg.Rules(big.NewInt(height), cfg.MergeNetsplitBlock != nil))
preCompiles := vm.DefaultActivePrecompiles(cfg.Rules(big.NewInt(height), cfg.MergeNetsplitBlock != nil, uint64(time)))

Check failure

Code scanning / gosec

Potential integer overflow by integer type conversion Error

Potential integer overflow by integer type conversion
@mmsqe mmsqe marked this pull request as ready for review November 22, 2023 02:24
@mmsqe mmsqe enabled auto-merge (squash) November 22, 2023 10:14
@mmsqe mmsqe merged commit 6f3ad29 into crypto-org-chain:develop Nov 22, 2023
14 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants