Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: latest v1.11.x change is not included #381

Merged
merged 7 commits into from
Dec 7, 2023
Merged

Problem: latest v1.11.x change is not included #381

merged 7 commits into from
Dec 7, 2023

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Nov 24, 2023

Closes: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

mmsqe
mmsqe commented Nov 24, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 24, 2023
View reviewed changes
x/evm/keeper/state_transition.go
@@ -439,17 +439,17 @@
// calculate a minimum amount of gas to be charged to sender if GasLimit
// is considerably higher than GasUsed to stay more aligned with Tendermint gas mechanics
// for more info https://github.com/evmos/ethermint/issues/1085
gasLimit := sdk.NewDec(int64(msg.Gas()))
gasLimit := sdk.NewDec(int64(msg.GasLimit))

Check failure

Code scanning / gosec

Potential integer overflow by integer type conversion Error

Potential integer overflow by integer type conversion
@mmsqe mmsqe marked this pull request as ready for review November 24, 2023 03:42
@mmsqe mmsqe requested a review from yihuang November 24, 2023 03:42
mmsqe
mmsqe commented Dec 5, 2023
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@mmsqe mmsqe requested a review from yihuang December 7, 2023 05:23
yihuang
yihuang approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there are a few golang lint issues

@mmsqe mmsqe merged commit aaff96b into crypto-org-chain:develop Dec 7, 2023
13 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihuang yihuang yihuang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmsqe @yihuang