Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: disallow same sender tx appear in the same tx after contract #566

Merged
merged 7 commits into from
Dec 17, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Dec 17, 2024

creation

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yihuang yihuang requested a review from mmsqe December 17, 2024 07:42
app/ante/eth.go Outdated Show resolved Hide resolved
Signed-off-by: yihuang <[email protected]>
app/ante/eth.go Show resolved Hide resolved
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 20 lines in your changes missing coverage. Please review.

Project coverage is 46.15%. Comparing base (cd93407) to head (d71abad).
Report is 1 commits behind head on release/v1.4.x.

Files with missing lines Patch % Lines
app/ante/eth.go 32.00% 17 Missing ⚠️
app/ante/handler_options.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release/v1.4.x     #566      +/-   ##
==================================================
- Coverage           46.18%   46.15%   -0.03%     
==================================================
  Files                 181      181              
  Lines               18151    18179      +28     
==================================================
+ Hits                 8383     8391       +8     
- Misses               9048     9067      +19     
- Partials              720      721       +1     
Files with missing lines Coverage Δ
app/ante/handler_options.go 54.54% <0.00%> (-1.39%) ⬇️
app/ante/eth.go 75.49% <32.00%> (-6.08%) ⬇️

@yihuang yihuang enabled auto-merge (squash) December 17, 2024 09:09
@yihuang yihuang merged commit 21bd7ce into crypto-org-chain:release/v1.4.x Dec 17, 2024
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants