Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: sdk 0.52 is not used #568

Draft
wants to merge 80 commits into
base: develop
Choose a base branch
from
Draft

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Dec 31, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

gasBz := sdk.Uint64ToBigEndian(gas)
store.Set(types.KeyPrefixBlockGasWanted, gasBz)
if err := k.KVStoreService.OpenKVStore(ctx).Set(types.KeyPrefixBlockGasWanted, gasBz); err != nil {
panic(err)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 56.39600% with 392 lines in your changes missing coverage. Please review.

Project coverage is 46.04%. Comparing base (99985ec) to head (0f93966).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
app/app.go 84.28% 37 Missing and 7 partials ⚠️
app/export.go 4.54% 42 Missing ⚠️
server/start.go 10.52% 34 Missing ⚠️
testutil/network/network.go 0.00% 26 Missing ⚠️
client/testnet.go 0.00% 25 Missing ⚠️
testutil/app.go 12.50% 21 Missing ⚠️
app/upgrades.go 17.64% 11 Missing and 3 partials ⚠️
testutil/network/util.go 0.00% 14 Missing ⚠️
x/evm/keeper/keeper.go 70.73% 9 Missing and 3 partials ⚠️
client/keys.go 0.00% 10 Missing ⚠️
... and 43 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #568      +/-   ##
===========================================
- Coverage    46.18%   46.04%   -0.15%     
===========================================
  Files          181      181              
  Lines        18152    18247      +95     
===========================================
+ Hits          8384     8402      +18     
- Misses        9048     9110      +62     
- Partials       720      735      +15     
Files with missing lines Coverage Δ
app/ante/authz.go 81.63% <ø> (ø)
app/ante/eth.go 81.56% <100.00%> (ø)
app/ante/fee_checker.go 88.34% <100.00%> (+0.23%) ⬆️
app/ante/nativefee.go 57.33% <100.00%> (+1.63%) ⬆️
app/ante/setup.go 78.31% <100.00%> (-3.83%) ⬇️
crypto/codec/amino.go 100.00% <100.00%> (ø)
crypto/codec/codec.go 100.00% <100.00%> (ø)
encoding/codec/codec.go 100.00% <100.00%> (ø)
ethereum/eip712/encoding.go 76.15% <100.00%> (ø)
ethereum/eip712/encoding_legacy.go 73.43% <100.00%> (ø)
... and 75 more

Comment on lines +976 to +978
for addr := range GetMaccPerms() {
result[addr] = true
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant