Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add noble-based impl for fallback when BigInt is available #210

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ChALkeR
Copy link
Contributor

@ChALkeR ChALkeR commented Nov 15, 2024

Uses @noble/secp256k1-based implementation by default when bindings are unavailable but BigInt is available
If neither bindings nor BigInt are available, falls back to elliptic-based implementation

Entry point secp256k1/elliptic.js remains

This should be a non-breaking change

@ChALkeR ChALkeR changed the title feat: add noble impl for fallback when BigInt is available feat: add noble-based impl for fallback when BigInt is available Nov 15, 2024
@ChALkeR ChALkeR force-pushed the chalker/noble branch 3 times, most recently from 42a1549 to 3c5ae17 Compare November 15, 2024 03:06
@ChALkeR
Copy link
Contributor Author

ChALkeR commented Nov 15, 2024

Refactored code a bit for better unification with elliptic.js

@ChALkeR ChALkeR marked this pull request as ready for review November 15, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant