Skip to content

Commit

Permalink
test: fix Assertion only working on IOS (MetaMask#9852)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
- As assertion only seems to work for IOS in one of our regression tests
which fails regression builds in Bitrise
- This fixes the failure

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
Andepande authored Jun 5, 2024
1 parent 1f018ed commit 13580cf
Showing 1 changed file with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,13 @@ describe(
await DeleteWalletModal.tapDeleteMyWalletButton();
await TestHelpers.delay(2000);
await Assertions.checkIfVisible(OnboardingView.container);
await Assertions.checkIfVisible(await CommonView.toast);
if (device.getPlatform() === 'ios') {
await Assertions.checkIfVisible(await CommonView.toast);
}
await Assertions.checkIfNotVisible(await CommonView.toast);
await OnboardingView.tapCreateWallet();

//Create new wallet
// Create new wallet
await Assertions.checkIfVisible(MetaMetricsOptIn.container);
await MetaMetricsOptIn.tapAgreeButton();
await Assertions.checkIfVisible(CreatePasswordView.container);
Expand Down

0 comments on commit 13580cf

Please sign in to comment.