Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the nix flake #136

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Fix the nix flake #136

merged 4 commits into from
Jan 24, 2025

Conversation

Nadrieril
Copy link
Contributor

@Nadrieril Nadrieril commented Jan 23, 2025

The recent removal of Cargo.lock (#135) made the nix flake inoperant. This fixes the flake by making he bertie package take a pointer to a Cargo.lock as argument.

@Nadrieril
Copy link
Contributor Author

cc @karthikbhargavan

Copy link
Collaborator

@karthikbhargavan karthikbhargavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks right, even though I definitely don't know enough Nix to understand it. Does the CI generate the Cargo.lock each time?

@Nadrieril
Copy link
Contributor Author

Does the CI generate the Cargo.lock each time?

The circus-green CI does yes, and will keep the last-known-good Cargo.lock in its repo.

@msprotz
Copy link

msprotz commented Jan 24, 2025

This seems like the right thing to do to capture the idea of a "last known good" set of revisions.

We've been doing this with the everest script with good success over the years.

@franziskuskiefer franziskuskiefer merged commit 56313b8 into cryspen:main Jan 24, 2025
10 checks passed
@Nadrieril Nadrieril deleted the fix-flake branch January 24, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants