Manual benchmarks for PQClean #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franziskuskiefer
approved these changes
Aug 14, 2024
Yeah we should measure all the combinations eventually. Can you put that on an issue? |
…rux into jonas/ml-dsa-manual-benches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to compare to PQclean, I've replicated the manual benchmark approach for PQClean.
Note that the PQClean has internal randomness generation, compared to us, so I wonder if we should not include sampling the randomness in our part of the benchmark. We did not do this with the criterion benchmarks, so I didn't do it here for now.
Also, I've split the parameter set benchmarks, so you can run them individually. The bit where I include
bench_utils.rsvia#[path=...]is a bit nasty, let me know if I should try a different approach.Fixes #487