Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make more modules panic free #713

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Make more modules panic free #713

wants to merge 11 commits into from

Conversation

karthikbhargavan
Copy link
Contributor

No description provided.

@karthikbhargavan karthikbhargavan mentioned this pull request Dec 17, 2024
Merged
@mamonet mamonet requested a review from a team as a code owner December 20, 2024 06:57
@mamonet
Copy link
Member

mamonet commented Dec 20, 2024

I uploaded panic-free polynomial module (some functions have proofs)

@franziskuskiefer
Copy link
Member

This should be against main now.

@karthikbhargavan karthikbhargavan changed the base branch from dev to main December 20, 2024 07:45
franziskuskiefer
franziskuskiefer reviewed Dec 23, 2024
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally appears to be ok. But needs more context.
Please add some description on what this is doing.

@karthikbhargavan
Copy link
Contributor Author

Yes, I made this into a PR to get CI working on it, but it will go through one more round of work on Monday before I ask for a "real" review.

@franziskuskiefer franziskuskiefer marked this pull request as draft December 23, 2024 08:33
@franziskuskiefer
Copy link
Member

Yes, I made this into a PR to get CI working on it, but it will go through one more round of work on Monday before I ask for a "real" review.

I made it into a draft for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@karthikbhargavan karthikbhargavan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karthikbhargavan @mamonet @franziskuskiefer