Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: enhance TERMINFO for Linux builds #1187

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

elopez
Copy link
Member

@elopez elopez commented Feb 6, 2024

Some distros have terminfo on /usr/lib/terminfo, like Ubuntu. Others have them on /usr/share/terminfo, like Fedora. Include all possible paths to be as compatible as possible.

Closes #1185

Summary by CodeRabbit

  • Chores
    • Updated the TERMINFO variable path in the Nix package build process for improved compatibility.

Some distros have terminfo on /usr/lib/terminfo, like Ubuntu.
Others have them on /usr/share/terminfo, like Fedora. Include
all possible paths to be as compatible as possible.

Closes #1185
Copy link

coderabbitai bot commented Feb 6, 2024

Walkthrough

The modification primarily addresses an issue where Echidna v2.2.2 failed to find the xterm-256color terminfo entry by updating the TERMINFO path within the Nix package build process. This change aims to rectify the regression observed when transitioning from Echidna v2.2.1 to v2.2.2, ensuring compatibility and functionality in specified environments.

Changes

Files Change Summary
flake.nix Updated the TERMINFO variable path for echidna binary

Assessment against linked issues

Objective Addressed Explanation
Bug Identification and Regression in Behavior (#1185)
Contextual Information and Expected Behavior (#1185)
Version Information and Reproducibility (#1185) The specifics of how the change impacts version interoperability and reproducibility are not clear.

Poem

🐇 Oh, in the world of code and bin,
A tiny change makes the system grin.
🌟 No more errors, no more fright,
Echidna runs, into the night.
🎉 Hoppity hop, the bugs we fight!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@elopez elopez marked this pull request as ready for review February 6, 2024 18:28
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 603dc35 and c86ef95.
Files selected for processing (1)
  • flake.nix (1 hunks)
Additional comments: 1
flake.nix (1)
  • 103-103: The Perl script modifies the TERMINFO path to include multiple common locations. This change addresses the compatibility issue across different Linux distributions. However, ensure that the hardcoded paths are comprehensive and consider all potential TERMINFO locations across various distributions. Additionally, verify the length calculation (length($1) - 65) to ensure it correctly calculates the padding needed after the new paths are inserted.

@elopez elopez merged commit 88ccd4c into master Feb 6, 2024
18 checks passed
@elopez elopez deleted the dev-nix-fix-linux-terminfo branch February 6, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug-Candidate]: setupTerm: Couldn't look up terminfo entry "xterm-256color" in v2.2.2
1 participant