-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nix: enhance TERMINFO for Linux builds #1187
Conversation
Some distros have terminfo on /usr/lib/terminfo, like Ubuntu. Others have them on /usr/share/terminfo, like Fedora. Include all possible paths to be as compatible as possible. Closes #1185
WalkthroughThe modification primarily addresses an issue where Echidna v2.2.2 failed to find the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- flake.nix (1 hunks)
Additional comments: 1
flake.nix (1)
- 103-103: The Perl script modifies the TERMINFO path to include multiple common locations. This change addresses the compatibility issue across different Linux distributions. However, ensure that the hardcoded paths are comprehensive and consider all potential TERMINFO locations across various distributions. Additionally, verify the length calculation (
length($1) - 65
) to ensure it correctly calculates the padding needed after the new paths are inserted.
Some distros have terminfo on /usr/lib/terminfo, like Ubuntu. Others have them on /usr/share/terminfo, like Fedora. Include all possible paths to be as compatible as possible.
Closes #1185
Summary by CodeRabbit