-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checkers for lab 2 #79
Conversation
...ware-stack/high-level-languages/drills/tasks/high-level-lang/solution/tests/run_all_tests.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my inline commenst. Add TODOs to libc/drills/tasks/libc/
for each task in the README.md
file.
chapters/software-stack/applications/drills/tasks/app-investigation/generate_skels.py
Show resolved
Hide resolved
chapters/software-stack/high-level-languages/drills/tasks/high-level-lang/generate_skels.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a big TODO
to this file that would remove the entire awk
command upon running the generator script so that students can use their own approach.
chapters/software-stack/high-level-languages/drills/tasks/high-level-lang/solution/src/hello.go
Outdated
Show resolved
Hide resolved
...ware-stack/high-level-languages/drills/tasks/high-level-lang/solution/tests/run_all_tests.py
Outdated
Show resolved
Hide resolved
...ware-stack/high-level-languages/drills/tasks/high-level-lang/solution/tests/run_all_tests.py
Outdated
Show resolved
Hide resolved
69803fb
to
813ce9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only made a minimal pass. Go ahead and rebase this branch and add the checker for common-functions/
following the existing model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can easily check this task by adding the call to strcat()
directly into this file. You can use this infrastructure: https://github.com/cs-pub-ro/operating-systems/tree/main/content/chapters/data/lab/support/page-mapper/tests.
chapters/software-stack/high-level-languages/drills/tasks/high-level-lang/README.md
Show resolved
Hide resolved
chapters/software-stack/high-level-languages/drills/tasks/high-level-lang/README.md
Outdated
Show resolved
Hide resolved
39648b2
to
bcd7dc0
Compare
bcd7dc0
to
b21b1c3
Compare
Published at https://cs-pub-ro.github.io/operating-systems/79/ |
b21b1c3
to
092674a
Compare
5f2b603
to
b8e702b
Compare
- Generate the support code from the solutions using `generate_skels.py`. - Add checkers for the `common-functions` `high-level-lang` tasks. - Add `.output/` folder to `.gitignore` Signed-off-by: Andrei Miga <[email protected]> Signed-off-by: Teodor Dutu <[email protected]>
b8e702b
to
897400e
Compare
Prerequisite Checklist
Description of changes