Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkers for lab 2 #79

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

AndreiMiga77
Copy link

Prerequisite Checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Updated relevant documentation (if needed).

Description of changes

@github-actions github-actions bot added area/tasks Update to tasks topic/software-stack Related to "Software Stack" chapter kind/new New content / item labels Sep 30, 2024
Copy link

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my inline commenst. Add TODOs to libc/drills/tasks/libc/ for each task in the README.md file.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a big TODO to this file that would remove the entire awk command upon running the generator script so that students can use their own approach.

chapters/software-stack/libc/drills/tasks/libc/Makefile Outdated Show resolved Hide resolved
@AndreiMiga77 AndreiMiga77 force-pushed the AndreiMiga77/checkers branch 8 times, most recently from 69803fb to 813ce9b Compare October 10, 2024 22:55
Copy link

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only made a minimal pass. Go ahead and rebase this branch and add the checker for common-functions/ following the existing model.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can easily check this task by adding the call to strcat() directly into this file. You can use this infrastructure: https://github.com/cs-pub-ro/operating-systems/tree/main/content/chapters/data/lab/support/page-mapper/tests.

@AndreiMiga77 AndreiMiga77 force-pushed the AndreiMiga77/checkers branch 2 times, most recently from 39648b2 to bcd7dc0 Compare October 13, 2024 23:05
@teodutu teodutu added the needs-rendering The PR makes changes to the website that need to be rendered label Oct 13, 2024
Copy link

@github-actions github-actions bot added the kind/improve Improve / Update existing content / item label Oct 14, 2024
@teodutu teodutu force-pushed the AndreiMiga77/checkers branch 2 times, most recently from 5f2b603 to b8e702b Compare October 14, 2024 00:17
- Generate the support code from the solutions using
  `generate_skels.py`.
- Add checkers for the `common-functions` `high-level-lang` tasks.
- Add `.output/` folder to `.gitignore`

Signed-off-by: Andrei Miga <[email protected]>
Signed-off-by: Teodor Dutu <[email protected]>
@teodutu teodutu merged commit 7bd5a03 into cs-pub-ro:main Oct 14, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tasks Update to tasks kind/improve Improve / Update existing content / item kind/new New content / item needs-rendering The PR makes changes to the website that need to be rendered topic/software-stack Related to "Software Stack" chapter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants