-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
software-stack/lab: Remove backticks #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! What you need to do to make the checkpatch test pass [1] is to add the following line to your commit message:
Signed-off-by: <Your Name> <your email>
To do so, configure your user name and email like so:
git config --global user.name "Your Name"
git config --global user.email "your email"
Then run git commit --amend -s
to add the signed-off line automatically to your last commit. Finally, use git push -f
to replace your existing upstream commit with the one you've just amended. Then check the workflow runs to be all green.
f07a01f
to
bc4408d
Compare
Word should be past participle, not syscall name. Signed-off-by: PetruCristian <[email protected]>
bc4408d
to
cd328dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Do you know what caused the previous commit to fail checkpatch [1]? Specifically, why did the script want "petru.nania" <[email protected]>
to be your name and email? Where did it get those?
[1] https://github.com/cs-pub-ro/operating-systems/actions/runs/6578289290/job/17873100587#step:3:566
I authored the original commit with my university credentials I had been using for my operating systems assignment. I later changed to my personal credentials when signing off the commit but forgot to change the author's details.
Sent from Yahoo Mail on Android
On Thu, 19 Oct 2023 at 22:48, Teodor ***@***.***> wrote:
@teodutu approved this pull request.
👍
Do you know what caused the previous commit to fail checkpatch [1]? Specifically, why did the script want "petru.nania" ***@***.***> to be your name and email? Where did it get those?
[1] https://github.com/cs-pub-ro/operating-systems/actions/runs/6578289290/job/17873100587#step:3:566
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Makes sense. Thanks. |
Word should be past participle, not syscall name.