Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

software-stack/lab: Remove backticks #9

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

PetruCristian
Copy link

Word should be past participle, not syscall name.

@PetruCristian PetruCristian marked this pull request as draft October 19, 2023 15:19
@PetruCristian PetruCristian marked this pull request as ready for review October 19, 2023 15:21
Copy link

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! What you need to do to make the checkpatch test pass [1] is to add the following line to your commit message:

Signed-off-by: <Your Name> <your email>

To do so, configure your user name and email like so:

git config --global user.name "Your Name"
git config --global user.email "your email"

Then run git commit --amend -s to add the signed-off line automatically to your last commit. Finally, use git push -f to replace your existing upstream commit with the one you've just amended. Then check the workflow runs to be all green.

[1] https://github.com/cs-pub-ro/operating-systems/actions/runs/6576723181/job/17866991858?pr=9#step:3:566

Word should be past participle, not syscall name.

Signed-off-by: PetruCristian <[email protected]>
Copy link

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Do you know what caused the previous commit to fail checkpatch [1]? Specifically, why did the script want "petru.nania" <[email protected]> to be your name and email? Where did it get those?

[1] https://github.com/cs-pub-ro/operating-systems/actions/runs/6578289290/job/17873100587#step:3:566

@teodutu teodutu added the student-contrib Fix or improvement made by a student label Oct 19, 2023
@teodutu teodutu merged commit 3d93f22 into cs-pub-ro:main Oct 19, 2023
4 checks passed
@PetruCristian
Copy link
Author

PetruCristian commented Oct 19, 2023 via email

@teodutu
Copy link

teodutu commented Oct 19, 2023

Makes sense. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
student-contrib Fix or improvement made by a student
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants