Skip to content

Commit

Permalink
Added design vision for Wave 1 Voters
Browse files Browse the repository at this point in the history
  • Loading branch information
RJMurg committed Aug 12, 2024
1 parent ab8d448 commit fce87cf
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 6 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ Minimal modifications should be required to these voters to make them applicable

## Wave 1 Voters
- [SonarQube](./sonarqube/)
- Spell Check
- File Existence Checks
- Link Resolution Checks
- [Spell Check](./spell-check/)
- [File Existence Checks](./file-existence/)
- [Link Resolution Checks](./link-resolver/)

## Wave 2 Voters
- Container Build Checks
Expand Down
7 changes: 6 additions & 1 deletion file-existence/README.md
Original file line number Diff line number Diff line change
@@ -1,2 +1,7 @@
# File Existence Voter
TBF

## Design Vision
The file exisence voter should check that all files that are referenced actually exist in that path. This prevents broken links to files by way of typo, directory mistake or non-existing file.
For .env or other files that should be excluded, there should be a file (maybe .gitignore?) that gives link exceptions for the voter to ignore.

The voter should run during a branch push, or a PR and fail if any links fail to resolve.
7 changes: 6 additions & 1 deletion link-resolver/README.md
Original file line number Diff line number Diff line change
@@ -1,2 +1,7 @@
# Link Resolution Voter
TBF

## Design Vision
The link resolution voter should check all files for a URL by means of a regular expression (Except for localhost URLs) and ensure they actually resolve. This prevents broken links being introduced.
For localhost or other links that should be excluded, there should be a file that gives link exceptions for the voter to ignore.

The voter should run during a branch push, or a PR and fail if any links fail to resolve.
7 changes: 6 additions & 1 deletion spell-check/README.md
Original file line number Diff line number Diff line change
@@ -1,2 +1,7 @@
# Spell Check Voter
TBF

## Design Vision
The spell check voter should check HTML, Markdown, READMEs, etc. (any file which contains text that would be read by a user) and verify correct spelling.
For words specfic to the project, there should be a file which gives word exceptions for the voter to ignore.

The voter should run during a branch push, or a PR and fail if any typos are detected.

0 comments on commit fce87cf

Please sign in to comment.