Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

187044314 add to field #30

Merged
merged 11 commits into from
Feb 27, 2024
Merged

187044314 add to field #30

merged 11 commits into from
Feb 27, 2024

Conversation

ArushC
Copy link

@ArushC ArushC commented Feb 23, 2024

Pivotal Tracker Link

This is basically like 6 stories in one branch, so... yeah. But here is the original story:
https://www.pivotaltracker.com/story/show/187044314

What this PR does:

Summary of relevant changes:

  1. add the TO field to the email template and integrate with the backend. This required adding a "to" column to the EmailTemplate database, updating the view files, and changing the logic for how emails are sent out. To see changes reflected, run "rails db:migrate". See the corresponding RSpec test with Barney the purple dinosaur which verifies that the changes work.

  2. Fix the email template CRUD actions. There were two circumstances where if you entered invalid information when editing the email template or creating a new email template it would simply crash the app. So, I fixed it so that instead it displays flash messages. See the new Cucumber tests.

This pull request fixes|implements (pick one...) ______.

Include screenshots, videos, etc.

Who authored this PR?

Arush Chhatrapati

How should this PR be tested?

  • Is there a deploy we can view?

View the latest deployment at https://sp24-01-bjc-teachers-d0e972207d82.herokuapp.com/

  • What do the specs/features test?

RSpec test ensures that sending to multiple email addresses from the TO field works as expected, Cucumber tests ensure that the CRUD actions for the email template work as expected.

  • Are there edge cases to watch out for?

Are there any complications to deploying this?

Run "rails db:migrate"

Checklist:

  • Has this been deployed to a staging environment or reviewed by a customer?
  • Tag someone for code review (either a coach / team member)
  • I have renamed the branch to match PivotTracker's suggested one (necessary for BlueJay) (e.g. michael/12345-add-new-feature Any branch name will do as long as the story ID is there. You can use git checkout -b [new-branch-name])

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.77%. Comparing base (325fb70) to head (ac57d48).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   83.28%   85.77%   +2.49%     
==========================================
  Files          20       20              
  Lines         658      668      +10     
==========================================
+ Hits          548      573      +25     
+ Misses        110       95      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@perryzjc
Copy link
Member

@ArushC Looks good to me overall. Nice job.

The only concern I have is about the PR granularity, but it should be fine for this time. We can check with Micheal at next time's meeting.

@perryzjc perryzjc merged commit d9d096d into main Feb 27, 2024
8 checks passed
@perryzjc perryzjc deleted the 187044314-add-to-field branch February 27, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants