forked from beautyjoy/BJC-Teacher-Tracker
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
187044314 add to field #30
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s loaded on each run
…l template CRUD routes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 83.28% 85.77% +2.49%
==========================================
Files 20 20
Lines 658 668 +10
==========================================
+ Hits 548 573 +25
+ Misses 110 95 -15 ☔ View full report in Codecov by Sentry. |
@ArushC Looks good to me overall. Nice job. The only concern I have is about the PR granularity, but it should be fine for this time. We can check with Micheal at next time's meeting. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pivotal Tracker Link
This is basically like 6 stories in one branch, so... yeah. But here is the original story:
https://www.pivotaltracker.com/story/show/187044314
What this PR does:
Summary of relevant changes:
add the TO field to the email template and integrate with the backend. This required adding a "to" column to the EmailTemplate database, updating the view files, and changing the logic for how emails are sent out. To see changes reflected, run "rails db:migrate". See the corresponding RSpec test with Barney the purple dinosaur which verifies that the changes work.
Fix the email template CRUD actions. There were two circumstances where if you entered invalid information when editing the email template or creating a new email template it would simply crash the app. So, I fixed it so that instead it displays flash messages. See the new Cucumber tests.
This pull request fixes|implements (pick one...) ______.
Include screenshots, videos, etc.
Who authored this PR?
Arush Chhatrapati
How should this PR be tested?
View the latest deployment at https://sp24-01-bjc-teachers-d0e972207d82.herokuapp.com/
RSpec test ensures that sending to multiple email addresses from the TO field works as expected, Cucumber tests ensure that the CRUD actions for the email template work as expected.
Are there any complications to deploying this?
Run "rails db:migrate"
Checklist:
michael/12345-add-new-feature
Any branch name will do as long as the story ID is there. You can usegit checkout -b [new-branch-name]
)