Feature/187044317 add email resend flash message #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Pivotal Tracker Link][tracker]
https://www.pivotaltracker.com/n/projects/2406982/stories/187044317
What this PR does:
This pull request implements adding a flash message popup indicating whether the welcome email resend was a success or failure. A side note is that the new resend_welcome_email in the teachers_controller.rb now causes a new HTTP request to get sent after clicking resend, whereas the old one did not specify a redirect or render.
Include screenshots, videos, etc.
How should this PR be tested?
I added some RSpec tests to test for the flash message and redirect depending on verification status of account. Also manually tested with different types of accounts on the website to check flash message after clicking resend welcome email.
Is there a deploy we can view?
No, but it's relatively simple code.
What do the specs/features test?
Checking flash hash based on condition of teacher, and checking redirect afterwards.
Are there edge cases to watch out for?
No.
Are there any complications to deploying this?
No
Checklist:
michael/12345-add-new-feature
Any branch name will do as long as the story ID is there. You can usegit checkout -b [new-branch-name]
)