Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/187044317 add email resend flash message #31

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

JacksonXu33
Copy link

@JacksonXu33 JacksonXu33 commented Feb 26, 2024

[Pivotal Tracker Link][tracker]

https://www.pivotaltracker.com/n/projects/2406982/stories/187044317

What this PR does:

This pull request implements adding a flash message popup indicating whether the welcome email resend was a success or failure. A side note is that the new resend_welcome_email in the teachers_controller.rb now causes a new HTTP request to get sent after clicking resend, whereas the old one did not specify a redirect or render.

Include screenshots, videos, etc.

Screenshot 2024-02-25 160324

How should this PR be tested?

I added some RSpec tests to test for the flash message and redirect depending on verification status of account. Also manually tested with different types of accounts on the website to check flash message after clicking resend welcome email.

  • Is there a deploy we can view?
    No, but it's relatively simple code.

  • What do the specs/features test?
    Checking flash hash based on condition of teacher, and checking redirect afterwards.

  • Are there edge cases to watch out for?
    No.

Are there any complications to deploying this?

No

Checklist:

  • Has this been deployed to a staging environment or reviewed by a customer?
  • Tag someone for code review (either a coach / team member)
  • I have renamed the branch to match PivotTracker's suggested one (necessary for BlueJay) (e.g. michael/12345-add-new-feature Any branch name will do as long as the story ID is there. You can use git checkout -b [new-branch-name])

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.03%. Comparing base (2ee19ed) to head (3aefd1e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   81.95%   82.03%   +0.08%     
==========================================
  Files          20       20              
  Lines         654      657       +3     
==========================================
+ Hits          536      539       +3     
  Misses        118      118              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArushC
Copy link

ArushC commented Feb 26, 2024

Looks good to me. The RSpec tests seem to confirm that the feature works as expected. If anyone else wants to take a look, feel free, but otherwise I think this is ready to be merged into main.

@ArushC ArushC merged commit 928c57b into main Feb 26, 2024
10 checks passed
@ArushC ArushC deleted the feature/187044317-add-email-resend-flash-message branch February 26, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants