Adapted tokens to be external, CI now builds and installs the package, and unit tests are now using the installed package. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
glpatcern
reviewed
Aug 29, 2024
diocas
requested changes
Aug 29, 2024
rawe0
force-pushed
the
dev
branch
2 times, most recently
from
5b4613d
to
c642451
Compare
rawe0
force-pushed
the
dev
branch
3 times, most recently
from
e1a6843
to
70a2f42
Compare
diocas
requested changes
Sep 4, 2024
cs3client/file.py
Outdated
| # if the storage does not support locks, set the lock using xattr | ||
| if res.status.code == cs3code.CODE_UNIMPLEMENTED and self._config.lock_by_setting_attr: | ||
| self._config.lock_not_impl = True | ||
| self.set_lock(auth_token, resource, app_name, lock_id) |
There was a problem hiding this comment.
At this point you can directly call _set_lock_using_xattr
There was a problem hiding this comment.
I see that you changed it in this particular line. But when you have the same logic in different places, the idea is that you do the same for all of them :)
diocas
reviewed
Sep 6, 2024
cs3client/file.py
Outdated
| self._log.debug(f'msg="Using xattrs to execute RefreshLock" {resource.get_file_ref_str()}" value="{lock_id}"') | ||
| try: | ||
| currvalue = self.stat(auth_token, resource).arbitrary_metadata.metadata[LOCK_ATTR_KEY] | ||
| if currvalue.split("!")[0] == app_name \ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tokens are now handled externally to allow parallelism (makes the package stateless) which allows to user to reuse the connection in multiple threads. Methods for handling token operations (check_token, get_token) are still available and public to the user.
The CI has also been updated to build the package and install it using pip and the package structure has been corrected because of this. The unit tests now use the package that is installed instead of importing directly from the .py files, changes in the source code has also been made to reflect this change. This change is important because it tests that the package works as it should as a package.
The lock functionality has also been added.