Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved exception handling #8

Merged
merged 10 commits into from
Nov 5, 2024
+181 −159
Merged

Improved exception handling #8

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
508c8fc
Standardized error messages
glpatcern Sep 13, 2024
5ba8f34
Fixed lock handling in write_file
glpatcern Sep 13, 2024
63ed8be
Fixed type in set_xattr
glpatcern Sep 13, 2024
f8f393c
Unnest the exceptions package
glpatcern Sep 13, 2024
2acec4e
Better fix for lock metadata handling in write_file
glpatcern Sep 23, 2024
1985cdc
Fixed function signatures to uniformly use Optional[] as type hint wh…
glpatcern Oct 1, 2024
897250d
Do not force a type conversion as the type is hinted in the signature
glpatcern Oct 1, 2024
6d46363
Introduced a permission denied exception
glpatcern Oct 3, 2024
3501beb
Merge branch 'main' into exception-handling
glpatcern Oct 22, 2024
ae092cb
One more optional parameter
glpatcern Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions cs3client/file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,8 @@ def touch_file(self, auth_token: tuple, resource: Resource) -> None:
self._log.debug(f'msg="Invoked TouchFile" trace="{res.status.trace}"')

def write_file(
self, auth_token: tuple, resource: Resource, content: Union[str, bytes], size: int, lock_md: tuple = None
self, auth_token: tuple, resource: Resource, content: Union[str, bytes], size: int,
app_name: str = None, lock_id: str = None
glpatcern marked this conversation as resolved.
Show resolved Hide resolved
) -> None:
"""
Write a file using the given userid as access token. The entire content is written
Expand All @@ -182,16 +183,14 @@ def write_file(
:param resource: Resource to write content to
:param content: content to write
:param size: size of content (optional)
:param lock_md: tuple (<app_name>, <lock_id>) (optional)
:param app_name: application name (optional)
:param lock_id: lock id (optional)
:return: None (Success)
:raises: FileLockedException (File is locked),
:raises: AuthenticationException (Authentication failed)
:raises: UnknownException (Unknown error)

"""
app_name = lock_id = ''
if lock_md:
app_name, lock_id = lock_md
tstart = time.time()
# prepare endpoint
if size == -1:
Expand Down
Loading