Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarified scope of lock_id in InitiateFileUploadRequest #226

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Clarified scope of lock_id in InitiateFileUploadRequest #226

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce92aaa
Removed lock_id from InitiateFileUploadRequest
glpatcern Feb 14, 2024
002e7e3
Reinstated lock_id and added comments for clarification
glpatcern Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions cs3/storage/provider/v1beta1/provider_api.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,11 @@ service ProviderAPI {
// Initiates the download of a file using an
// out-of-band data transfer mechanism.
rpc InitiateFileDownload(InitiateFileDownloadRequest) returns (InitiateFileDownloadResponse);
// Initiates the upload of a file using an
// out-of-band data transfer mechanism.
// Initiates the upload of a file using an out-of-band data
// transfer mechanism. SHOULD return CODE_FAILED_PRECONDITION
// if the reference is already locked with a mismatched lock.
// Additionally, the lock check MUST be enforced by the data
// transfer protocol returned in response.
rpc InitiateFileUpload(InitiateFileUploadRequest) returns (InitiateFileUploadResponse);
// Returns the list of grants for the provided reference.
// MUST return CODE_NOT_FOUND if the reference does not exists.
Expand Down Expand Up @@ -371,7 +374,8 @@ message InitiateFileUploadRequest {
}
// OPTIONAL.
// A lock_id: should the reference exist and be locked, the stored
// lock_id MUST be equal to the given value.
// lock_id SHOULD be equal to the given value. Additionally, the
// check MUST be enforced by the out-of-band transfer protocol.
string lock_id = 5;
}

Expand Down