Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eosfs: Upload function does not take the lock into account #4371

Closed
glpatcern opened this issue Nov 28, 2023 · 0 comments · Fixed by #4514
Closed

eosfs: Upload function does not take the lock into account #4371

glpatcern opened this issue Nov 28, 2023 · 0 comments · Fixed by #4514
Assignees

Comments

@glpatcern
Copy link
Member

glpatcern commented Nov 28, 2023

Found when testing the eosgrpc driver. The issue is that a locked file cannot be overwritten (eos introduced a proper protection for this, used by wopiserver with the xroot interface).

To fix this we need to change the fs.Upload() signature and pass the lock context along. I noted that in Reva edge, the Upload function was already modified to receive the whole GRPC request payload, which contains the lock.

This is not super urgent - in particular, we can deploy eosgrpc in production while keeping the wopiserver use the xroot interface - but it needs to be fixed in order to support locks from Reva (for WOPI apps but also for SWAN).

For the eos driver implementation, it will be enough to pass an extra eos.app HTTP header to EOS on PUT.

@glpatcern glpatcern self-assigned this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant