Pass lock metadata on uploads + use upstream EOS GRPC bindings #4514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
glpatcern
force-pushed
the
locks-uploads
branch
8 times, most recently
from
9a8b893
to
36a072a
Compare
glpatcern
changed the title
glpatcern
force-pushed
the
locks-uploads
branch
from
36a072a
to
6597fea
Compare
glpatcern
force-pushed
the
locks-uploads
branch
from
6597fea
to
a6e7ccf
Compare
glpatcern
force-pushed
the
locks-uploads
branch
from
2885699
to
fce392e
Compare
glpatcern
force-pushed
the
locks-uploads
branch
2 times, most recently
from
9e48ccf
to
f2854e1
Compare
glpatcern
force-pushed
the
locks-uploads
branch
from
d9cfec1
to
7d832dc
Compare
glpatcern
force-pushed
the
locks-uploads
branch
2 times, most recently
from
4c66e0f
to
2e8b265
Compare
labkode
reviewed
Aug 13, 2024
labkode
reviewed
Aug 13, 2024
labkode
reviewed
Aug 13, 2024
labkode
reviewed
Aug 13, 2024
labkode
reviewed
Aug 13, 2024
labkode
reviewed
Aug 13, 2024
glpatcern
force-pushed
the
locks-uploads
branch
3 times, most recently
from
e987a60
to
1140ae7
Compare
labkode
previously approved these changes
Aug 14, 2024
private as only used by eosbinary.go
glpatcern
force-pushed
the
locks-uploads
branch
from
1140ae7
to
6cafefe
Compare
* ocm: fixed domain not having a protocol scheme * changelog * changelog * fix possible bug due to uppercase and lowercase string in domain * lint: add space after // in comments * Instead of modifying domain, use a new var endpoint
labkode
approved these changes
Aug 30, 2024
labkode
pushed a commit
to labkode/reva
that referenced
this pull request
Sep 9, 2024
glpatcern
added a commit
to glpatcern/reva
that referenced
this pull request
Sep 13, 2024
glpatcern
added a commit
that referenced
this pull request
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now pass relevant metadata (lock id and lock holder) downstream on uploads and on xattr operations, and handle the case of conflicts due to lock mismatch. The full implementation is only for eos (and requires eos 5.2.22+ on the server), cephfs is TODO.
Relates to cs3org/wopiserver#139
Edit: the EOS GRPC bindings are taken from https://github.com/cern-eos/go-eosgrpc/