keep failed processing status #4470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
commented
Jan 23, 2024
| @@ -261,7 +263,7 @@ func (upload *Upload) FinishUpload(_ context.Context) error { | |||
|
|
|||
| n, err := CreateNodeForUpload(upload, attrs) | |||
| if err != nil { | |||
| Cleanup(upload, true, false) | |||
| Cleanup(upload, true, false, true) | |||
There was a problem hiding this comment.
postprocessing has not started, yet, so we might change this to
Suggested change
| Cleanup(upload, true, false, true) | |
| Cleanup(upload, true, false, false) |
opinions?
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
2403905
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #4449 to stable 2.16
also requires backport of #4451
full ocis ci run in owncloud/ocis#8262