fixed the race condition that led to concurrent map access in a publicshare manager #4472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobergj
requested changes
Jan 23, 2024
| @@ -414,6 +417,9 @@ func (m *manager) UpdatePublicShare(ctx context.Context, u *user.User, req *link | |||
|
|
|||
| // GetPublicShare gets a public share either by ID or Token. | |||
| func (m *manager) GetPublicShare(ctx context.Context, u *user.User, ref *link.PublicShareReference, sign bool) (*link.PublicShare, error) { | |||
| m.mutex.Lock() | |||
There was a problem hiding this comment.
Can we change this to use a sync.RWMutex instead? We could RLock here for improved performance.
There was a problem hiding this comment.
We can't, because we call revokeExpiredPublicShare inside and it lead to the m.persistence.Write() call
kobergj
approved these changes
Jan 23, 2024
butonic
approved these changes
Jan 23, 2024
|
since this is only for the json manager I'm fine with all the mutexes ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue owncloud/ocis#8255