Fix broken PROPFIND permissions in projects over gRPC #4901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
jessegeens
force-pushed
the
fix/broken-perms-project
branch
from
156848b
to
7839a80
Compare
The permissions returned by PROPFIND on a folder in a project were erroneous because ACL permissions were being ignored. This stems from a bug in grpcMDResponseToFileInfo, where the SysACL attribute of the FileInfo struct was not being populated.
jessegeens
force-pushed
the
fix/broken-perms-project
branch
from
7839a80
to
950b1c5
Compare
diocas
requested changes
Oct 28, 2024
diocas
approved these changes
Oct 29, 2024
glpatcern
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The permissions returned by
PROPFINDon a folder in a project were erroneous because ACL permissions were being ignored. This stems from a bug ingrpcMDResponseToFileInfo, where theSysACLattribute of theFileInfostruct was not being populated.