Fix bug in ListDeletedEntries where the PurgeDate was not set correctly #4905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
jessegeens
force-pushed
the
fix/trashbin-grpc
branch
from
a0d6db3
to
b13c963
Compare
jessegeens
requested review from
labkode,
glpatcern and
diocas
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The date range that can be passed to
ListDeletedEntrieswas not taken into account due to a bug in reva: thePurgedateargument was set, which only works forPURGErequests, and not forLISTrequests. Instead, theListflagargument must be used. Additionally, there was a bug in the loop that is used to iterate over all days in the date range.