Tian/update #140
Tian/update #140
Conversation
|
@mdpiper I made some text edits in the notebook. Could you please help merge this branch? Thank you! |
lessons/python/rainfall_runoff.ipynb
Outdated
| "display_name": "Ivy", | ||
| "display_name": "Python 3 (ipykernel)", | ||
| "language": "python", | ||
| "name": "ivy" | ||
| "name": "python3" |
There was a problem hiding this comment.
@gantian127 Could you revert these to Ivy/ivy, please?
There was a problem hiding this comment.
@mdpiper There should be a linter for this. Did you disable it? Was it not working correctly?
There was a problem hiding this comment.
@mcflugen I didn't see it in the latest heartfelt-hooks. Did the name change, or did I just miss it?
There was a problem hiding this comment.
It's not there anymore but it's still in my version. Maybe I just added it to a branch I was working on and never merged it. If you like, I can create a pull request that adds it. It should just be adding something like the following under the heartfelt-hooks section,
- id: nb-check-kernel
args: [
--verbose,
--fix,
--kernel-name=ivy,
--kernel-display-name=Ivy,
--kernel-language=python
]There was a problem hiding this comment.
If you add it to heartfelt-hooks & bump the release, I'll add the hook back to the Ivy .pre-commit-config.yaml.
|
@mdpiper I reverted Ivy/ivy back. Thanks! |
|
@gantian127 Thanks! |
Updated the text in the rainfall_runoff notebook.