Skip to content

Commit

Permalink
ci: drop linux/arm/v7 from the platforms for building container-images
Browse files Browse the repository at this point in the history
There is not need for `secrets.BUILD_PLATFORMS`, as the platforms are
not confidential. Instead a variable has been created in the GitHub
repository settings for it now.

The `secrets.BUILD_PLATFORMS` includes linux/arm/v7, which is a slow and
phased out architecture. All reasonable ARM platforms are linux/arm64
now. Dropping the linux/arm/v7 platform makes building the container
images much faster.

Closes: #719
Signed-off-by: Niels de Vos <[email protected]>
  • Loading branch information
nixpanic committed Nov 28, 2024
1 parent f037599 commit 0d6ad49
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build-push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
with:
context: .
file: Dockerfile
platforms: ${{ secrets.BUILD_PLATFORMS }}
platforms: ${{ vars.BUILD_PLATFORMS }}
push: true
tags: quay.io/csiaddons/k8s-controller:latest

Expand Down Expand Up @@ -95,6 +95,6 @@ jobs:
with:
context: .
file: build/Containerfile.sidecar
platforms: ${{ secrets.BUILD_PLATFORMS }}
platforms: ${{ vars.BUILD_PLATFORMS }}
push: true
tags: quay.io/csiaddons/k8s-sidecar:latest
4 changes: 2 additions & 2 deletions .github/workflows/test-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
with:
context: .
file: Dockerfile
platforms: ${{ secrets.BUILD_PLATFORMS }}
platforms: ${{ vars.BUILD_PLATFORMS }}
push: false
tags: quay.io/csiaddons/k8s-controller:latest

Expand All @@ -74,6 +74,6 @@ jobs:
with:
context: .
file: build/Containerfile.sidecar
platforms: ${{ secrets.BUILD_PLATFORMS }}
platforms: ${{ vars.BUILD_PLATFORMS }}
push: false
tags: quay.io/csiaddons/k8s-sidecar:latest

0 comments on commit 0d6ad49

Please sign in to comment.