ci: use docker-generate-protobuf by default in Makefile #663
Conversation
mergify
bot
requested review from
black-dragon74,
iPraveenParihar,
Madhu-1,
nixpanic and
yati1998
|
We need to update protobuf versions inside the tools container as well. |
Rakshith-R
force-pushed
the
docker-protoc
branch
from
99a9fbd to
a5154fd
Compare
where exactly ? |
| @@ -1,7 +1,7 @@ | |||
| // Code generated by protoc-gen-go. DO NOT EDIT. | |||
| // versions: | |||
| // protoc-gen-go v1.34.2 | |||
| // protoc v3.20.2 | |||
| // protoc v3.19.6 | |||
There was a problem hiding this comment.
We should keep this to the same version as we have in GitHub action
is the place we are installing this in fedora or remove installing protobuf in the GitHub action, we need to be consistency
There was a problem hiding this comment.
I'd prefer to remove the protoc installation in the github action. The CI job calls make test, so it should run in the container now too.
There was a problem hiding this comment.
Once this is addressed, it should be good to go.
Right now the tools container uses the latest available version from Fedora. We should pin the version to that in the spec repo. We could have something like this for protoc tools. |
| @@ -1,7 +1,7 @@ | |||
| // Code generated by protoc-gen-go. DO NOT EDIT. | |||
| // versions: | |||
| // protoc-gen-go v1.34.2 | |||
| // protoc v3.20.2 | |||
| // protoc v3.19.6 | |||
There was a problem hiding this comment.
Once this is addressed, it should be good to go.
|
@Rakshith-R please update this, or let me know if you want me to take it over. Thanks! |
This commit modifies Makefile to use docker-generate-protobuf instead of generate-protobuf by default. Signed-off-by: Rakshith R <[email protected]>
The GitHub workflow calls `make test`, which runs the protoc installation and (re)generation of files inside a container. There is no need to install protoc in the workflow anymore. Signed-off-by: Niels de Vos <[email protected]>
nixpanic
force-pushed
the
docker-protoc
branch
from
d6a4d7d to
ec9dcbf
Compare
This commit modifies Makefile to use docker-generate-protobuf instead of generate-protobuf by default.