Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: add NetworkFenceClass CRD #698

Merged
merged 1 commit into from
Nov 5, 2024
Merged

api: add NetworkFenceClass CRD #698

merged 1 commit into from
Nov 5, 2024

Conversation

Madhu-1
Copy link
Member

@Madhu-1 Madhu-1 commented Oct 30, 2024

Adding NetworkFenceClass which is going to be used to get the client details to be fenced.

The controller will watch for the NetworkFenceClass CR and sends a periodic request to all the sidecars registered with the matching driver name that registered the GET_CLIENTS_TO_FENCE caps to get the client details, once the controller gets the client details its will update the CSIAddonsNode object status with the client information that can be used to do Network fencing and unfencing.

@mergify mergify bot added the api Change to the API, requires extra care label Oct 30, 2024
Copy link
Collaborator

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a description to the documentation so that it becomes easier to understand what this is about.

@Madhu-1
Copy link
Member Author

Madhu-1 commented Oct 31, 2024

Consider adding a description to the documentation so that it becomes easier to understand what this is about.

updated the PR descriptions, will follow with the controller and sidecar implementation and the documentation

Copy link
Member

@black-dragon74 black-dragon74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Collaborator

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let me know if you want to correct the year in the header.

@Madhu-1
Copy link
Member Author

Madhu-1 commented Nov 5, 2024

LGTM, let me know if you want to correct the year in the header.

@nixpanic will take care of in followup PR

@Madhu-1 Madhu-1 requested a review from nixpanic November 5, 2024 11:20
adding NetworkFenceClass which is
going to be used to get the client
details to be fenced.

The controller will watch for the NetworkFenceClass
CR and sends a periodic request to all
the sidecars registered with the matching
driver name that registered the
GET_CLIENTS_TO_FENCE caps to get the client
details, once the controller gets the client
details its going to update the CSIAddonsNode
object status with the client information that
can be used to do Network fencing and unfencing.

Signed-off-by: Madhu Rajanna <[email protected]>
@mergify mergify bot merged commit 33071c3 into csi-addons:main Nov 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Change to the API, requires extra care
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants