-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: add NetworkFenceClass CRD #698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a description to the documentation so that it becomes easier to understand what this is about.
updated the PR descriptions, will follow with the controller and sidecar implementation and the documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let me know if you want to correct the year in the header.
@nixpanic will take care of in followup PR |
adding NetworkFenceClass which is going to be used to get the client details to be fenced. The controller will watch for the NetworkFenceClass CR and sends a periodic request to all the sidecars registered with the matching driver name that registered the GET_CLIENTS_TO_FENCE caps to get the client details, once the controller gets the client details its going to update the CSIAddonsNode object status with the client information that can be used to do Network fencing and unfencing. Signed-off-by: Madhu Rajanna <[email protected]>
Adding NetworkFenceClass which is going to be used to get the client details to be fenced.
The controller will watch for the NetworkFenceClass CR and sends a periodic request to all the sidecars registered with the matching driver name that registered the GET_CLIENTS_TO_FENCE caps to get the client details, once the controller gets the client details its will update the CSIAddonsNode object status with the client information that can be used to do Network fencing and unfencing.