csiaddons: allow deleting of the CR #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
requested review from
black-dragon74,
iPraveenParihar,
nixpanic,
Rakshith-R and
yati1998
The pod is set as the owner of the csiaddons node object, and when the owner pod is deleted the csiaddons need to be deleted as well, When the delete Reconciles happens we cannot get the pod deletails to resolve the endpoint and we dont need that as well when we are deleting the CR. Signed-off-by: Madhu Rajanna <[email protected]>
Madhu-1
force-pushed
the
fix-delete-bug
branch
from
ccb88fe to
be33795
Compare
Rakshith-R
approved these changes
Dec 5, 2024
iPraveenParihar
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pod is set as the owner of the csiaddons node object, and when the owner pod is deleted the csiaddons need to be deleted as well, When the delete Reconciles happens we cannot get the pod deletails to resolve the endpoint and we dont
need that as well when we are deleting the CR.