Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/exports-maps for consistent behaviour of esm imports in node and browser environments #1552

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Feat/exports-maps for consistent behaviour of esm imports in node and browser environments #1552

wants to merge 11 commits into from

Commits on Sep 8, 2021

  1. Adding exports map and upgrading @babel/runtime for better esm intero… 

    …p in node
    @JayaKrishnaNamburu @kof
    JayaKrishnaNamburu authored and kof committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    0f3dfae View commit details
    Browse the repository at this point in the history

  2. Upgrade to latest version os is-in-browser for proper esm imports

    @JayaKrishnaNamburu @kof
    JayaKrishnaNamburu authored and kof committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    c1aeb99 View commit details
    Browse the repository at this point in the history

  3. Fixing tests for reset moduleId

    @JayaKrishnaNamburu @kof
    JayaKrishnaNamburu authored and kof committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    48c2c61 View commit details
    Browse the repository at this point in the history

  4. Fixing test for createGenerateId

    @JayaKrishnaNamburu @kof
    JayaKrishnaNamburu authored and kof committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    d285ee0 View commit details
    Browse the repository at this point in the history

  5. reset sheets before all tests, use global jss resolution in tests/utils 

    For some reason using relative path is not resolving to the same module and sheets are being reseted in the wrong module scope for everyhing except the jss package.

So now jss package passes the sheets registry instance manually
    @kof
    kof committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    b669277 View commit details
    Browse the repository at this point in the history

  6. remove circular dependencies

    @kof
    kof committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    deb0d33 View commit details
    Browse the repository at this point in the history

  7. add check:types for convenience

    @kof
    kof committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    b73c9c8 View commit details
    Browse the repository at this point in the history

  8. revert to static id in moduleId with no functions

    @kof
    kof committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    9c55190 View commit details
    Browse the repository at this point in the history

  9. changelog for 1552

    @kof
    kof committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    9878cd7 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. fix wrong usage of resetSheets

    @kof
    kof committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    22507d6 View commit details
    Browse the repository at this point in the history

  2. no need to double detach, lets keep it lower level

    @kof
    kof committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    9581ef1 View commit details
    Browse the repository at this point in the history