csgrep --imp-level=1: filter out important defects #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... so that we can use the former while implementing the latter. No changes in behavior intended with this commit.
... so that a failure is handled in the `if` block. No changes in behavior intended with this commit.
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Sep 27, 2023
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Sep 27, 2023
Depends on: csutils/csdiff#143 Related: https://issues.redhat.com/browse/OSH-289 Closes: csutils#125
|
Hey @kdudka! I looked at the code and I didn't find any major issues. Nevertheless, I may not be the perfect candidate to do code review for C. I also added @hanchuntao as a reviewer to see if he can take a look |
|
Thanks! I should have written that the only significant change is the commit 356904a. The other two commits are just moving code around. |
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Sep 29, 2023
Depends on: csutils/csdiff#143 Related: https://issues.redhat.com/browse/OSH-289 Closes: csutils#125
|
@jamacku Thanks for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: https://issues.redhat.com/browse/OSH-289