Skip to content

Commit

Permalink
results: reset imp flag in the list of important findings only
Browse files Browse the repository at this point in the history
Tagging important findings does not make sense in the list of important
findings only.

Resolves: https://issues.redhat.com/browse/OSH-343
  • Loading branch information
kdudka committed Nov 9, 2023
1 parent 2e89ad7 commit a821edd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion make-srpm.sh
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ Tool for plugging static analyzers into the build process, free of mock.
%package -n csmock-common
Summary: Core of csmock (a mock wrapper for Static Analysis tools)
Requires: csdiff > 3.0.4
Requires: csdiff > 3.1.0
Requires: csgcca
Requires: cswrap
Requires: mock
Expand Down
2 changes: 1 addition & 1 deletion py/common/results.py
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ def finalize_results(js_file, results, props):
% (js_file, chk_re, csgrep_args)

# finally take all defects that were tagged important by the scanner already
cmd += f" | csgrep --mode=json <(csgrep --mode=json --imp-level=1 '{js_file}') -"
cmd += f" | csgrep --mode=json --set-imp-level=0 <(csgrep --mode=json --imp-level=1 '{js_file}') -"

Check warning

Code scanning / vcs-diff-lint

Line too long (107/100) Warning

Line too long (107/100)

# write the result into *-imp.js
imp_js_file = re.sub("\\.js", "-imp.js", js_file)
Expand Down

0 comments on commit a821edd

Please sign in to comment.